fix(server setup): Added MaxConcurrentReconciles to server manager setup #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good find |
cristiGuranIonos
previously approved these changes
Nov 21, 2024
| @@ -55,7 +55,8 @@ func Setup(mgr ctrl.Manager, opts *utils.ConfigurationOptions) error { | |||
| return ctrl.NewControllerManagedBy(mgr). | |||
| Named(name). | |||
| WithOptions(controller.Options{ | |||
There was a problem hiding this comment.
I think opts.CtrlOpts.ForControllerRuntime() can be used too. But this works as well.
There was a problem hiding this comment.
Nice find I didn't see that method, I think it would be wise to use that instead so that if anything new is added in future they get picked up by default. Did you want me to edit all the other resources as well or leave it just as server for now?
|
cristiGuranIonos
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I noticed that despite increasing the max-reconcile-rate flag the number of workers assigned to each resource was remaining at 1, and that the max-reconcile-rate was only actually being used to adjust the GlobalRateLimiter (relevant P.S below). This also appears to be the case for all the other resources as well but I haven't been having scaling problems with those resources so didn't wish to over complicate the PR.
P.S I don't think the global rate limiter is being used either as the line underneath the one this PR adds just instantiates a new rate limiter with default settings)
This PR adds:
Checklist
Minor code change that requires no documentation / test changes
I have:
feat/fix/doc/test/refactor)make reviewableandmake crds.cleanto ensure the PR is ready for reviewmake docs.update(if applicable)docs/CHANGELOG.mdfile (label:upcoming release)